Skip to content

All Tests Pass #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

All Tests Pass #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/About.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ import React from "react";
import { image } from "../data/data";

function About() {
return <div>About</div>;
return (
<div id="about">
<h2>About Me</h2>
<p>Hello world</p>
<img src={image} alt="I made this"/>
</div>
)
Comment on lines +5 to +11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return (
<div id="about">
<h2>About Me</h2>
<p>Hello world</p>
<img src={image} alt="I made this"/>
</div>
)
return (
<div id="about">
<h2>About Me</h2>
<p>Hello world</p>
<img src={image} alt="I made this"/>
</div>
)

}

export default About;
6 changes: 5 additions & 1 deletion src/components/Home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { name, city } from "../data/data.js";

function Home() {
// update the JSX being returned!
return <div>Home</div>;
return (
<div id="home">
<h1 style={{color: "firebrick"}}>{name} is a Web Developer from {city}</h1>
</div>
)
}

export default Home;
7 changes: 6 additions & 1 deletion src/components/NavBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import React from "react";

function NavBar() {
// update the JSX being returned!
return <nav>NavBar</nav>;
return (
<nav>
<a href="#home">Home</a>
<a href="#about">About</a>
</nav>
)
}

export default NavBar;