-
Notifications
You must be signed in to change notification settings - Fork 231
Description
Observed behavior
This is a follow up issue on #4472
contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js
fails to run during tests execution when migrated to KCheckbox
. It's likely related to the rules
and hide-details
props that have been removed from the Checkbox.vue
component and yet are used in the Create.vue
component.
studio/contentcuration/contentcuration/frontend/accounts/pages/Create.vue
Lines 135 to 142 in dbb5a63
<Checkbox | |
v-model="acceptedAgreement" | |
:label="$tr('agreement')" | |
required | |
:rules="tosAndPolicyRules" | |
:hide-details="false" | |
class="my-1 policy-checkbox" | |
/> |
The work around was to use the VCheckbox
instead of the Checkbox
, since it has the props in question.
Expected behavior
- The
Create
component should be migrated toKCheckbox
- The failing tests should run and pass.
User-facing consequences
None
Errors and logs
FAIL contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js
● Test suite failed to run
Call retries were exceeded
at ChildProcessWorker.initialize (node_modules/jest-worker/build/workers/ChildProcessWorker.js:193:21)
Additional information
We don't need to implement hide-details
or rules
necessarily. Since this page is the only place where we're using checkbox rules, we can just implement the validation directly in the component. Additionally, it needs to display the error message underneath the field, which hide-details=false
allows space for.
Steps to reproduce the issue
- Change VCheckbox in Create.vue to Checkbox
- Run the test suites using the
yarn run test