-
Notifications
You must be signed in to change notification settings - Fork 215
Closed
Labels
help wantedOpen source contributors welcomeOpen source contributors welcome
Description
Desired behavior
We should remove all mentions and usage of material-icons and replace with usage of Kolibri Design System icons where possible. Where not possible, we should just remove it (as in the base.html file).
Current behavior
We rely on an extra dependency for icons that has an unclear upgrade path.
Fixing this issue will not allow us to remove the dependency, as Vuetify still requires it, but takes us one step closer.
Metadata
Metadata
Assignees
Labels
help wantedOpen source contributors welcomeOpen source contributors welcome
Type
Projects
Relationships
Development
Select code repository
Activity
SukhvirKooner commentedon Feb 11, 2025
Hi @rtibbles,
I’d like to take on this issue. Could you clarify whether there are any specific guidelines or references for implementing Kolibri Design System icons? Also, are there any high-priority sections where this change should be made first?
Please assign this to me. Thanks!
rtibbles commentedon Feb 11, 2025
Search for
material-icons
in the codebase would be the first start to identify places that need to be updated. Once you've identified what icons are being used, you can cross reference with https://design-system.learningequality.org/icons to see what icons we could replace them with.It's also possible there are references where it is not being used at all, so we might be able to just remove at those points.
SukhvirKooner commentedon Feb 14, 2025
Hi @rtibbles ,
I have raised the PR to replace
material-icons
with Kolibri Design System icons.Let me know if changes are needed. Looking forward to your feedback!
MisRob commentedon Feb 17, 2025
Thank you @SukhvirKooner, we will review
ishaan-arora-1 commentedon Mar 11, 2025
it seems like this issue is still open, i'd like to work on it if it is... apologies otherwise.
MisRob commentedon Mar 11, 2025
Hi @ishaan-arora-1, what my colleague mentioned in the other comment applies here as well. We won't assign issues that are already assigned. I would recommend you examine issues carefully - I think you should be able to see the assignment section?
Generally, it's best to follow the process in the CONTRIBUTING.md. There are no 'help wanted' now so I recommend to refresh the list on weekly basis as we keep adding. Before then, we can't assign you any issues. Thanks for your interest and hopefully some time later we can collaborate.
ishaan-arora-1 commentedon Mar 11, 2025
@MisRob I'm really sorry for the misunderstanding on my part. I was just really eager to contribute after using everything at Learning Equality. I thought that since the issue was still open even after the PR, I could ask to be assigned, but I now realize that was my mistake. Sorry again for the inconvenience!
MisRob commentedon Mar 11, 2025
No problem - actually thanks for sharing more @ishaan-arora-1. It will help me to understand how people perceive issues.
Yes, sometimes there is an issue open for a long time even after the PR. We clear up stale assignments regularly though, so checking on assignees will do.