Skip to content

Conversation

ShivangRawat30
Copy link
Contributor

This pull request replaces occurrences of the router-Link tag with KrouterLink.

Summary

Description of the change(s) you made

learningequality/kolibri-design-system#219

Reviewer guidance

How can a reviewer test these changes?

If this pull request is accepted and merged, I plan to submit additional pull requests addressing other issue with more extensive changes. The current pull request contains only minor modifications related to that issue.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShivangRawat30! Your changes look correct to me. 🎉
Tagging @radinamatic @pcenov for the final round of manual QA before a merge can happen

@akolson akolson requested a review from radinamatic September 26, 2023 16:25
@radinamatic
Copy link
Member

@akolson Would it be possible to have some details of what would be the best approach for the manual QA? Any specific steps or parts of the application that need deeper testing? Is there a user workflow that is the most likely to break because of the changes in this PR, etc.?

@akolson
Copy link
Member

akolson commented Sep 26, 2023

@radinamatic. However, there are two others that I failed to figure out where they belong on the UI.
Screenshot 2023-09-27 at 00 06 01
Screenshot 2023-09-27 at 00 10 06

Hopefully this helps

@MisRob
Copy link
Member

MisRob commented Sep 27, 2023

Thanks @ShivangRawat30!

If this pull request is accepted and merged, I plan to submit additional pull requests addressing other issue with more extensive changes.

As soon as you continue, could you please reference the updated places in a PR description, similarly to how @akolson did in the comment above? I assume that you test those places manually as you work, so it should be just a moment of taking a screenshot. It doesn't need to be extremely detailed, only so that our QA team knows what places to click through. It would be very helpful for smooth review process.

@ShivangRawat30
Copy link
Contributor Author

@MisRob I will make sure to incorporate this into my future contributions. Thank you for your guidance.

@MisRob MisRob requested a review from pcenov September 30, 2023 10:27
@MisRob MisRob merged commit 7d8101b into learningequality:unstable Oct 6, 2023
@MisRob
Copy link
Member

MisRob commented Oct 6, 2023

Merging as @pcenov mentioned he will be testing this in unstable

@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants