Skip to content

Conversation

Abhishekzod007
Copy link
Contributor

@Abhishekzod007 Abhishekzod007 commented Feb 11, 2024

Summary

Description of the change(s) you made

Firstly I found out the position where that particular file is located and it took a lot of time to find and then did some changes there by putting and deleting values so that I can check updates on the actual website. This is an attempt to solve issue #4171

Manual verification steps performed

  1. On website's page , I went on Inspect then by putting manually values I check the behaviour of "Folder Button".
  2. By committing changes in the code then restarted the server and it started working properly.

Reviewer guidance

I have only changed the value of that particular width.

References

Closes #4171
Includes update for #4418 (minus tests TBC)

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@Abhishekzod007
Copy link
Contributor Author

Hii @bjester , can you please review it?. So that I'll have better idea, if I have to work more on this or it is enough.

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishekzod007 I left some comments on your solution here


send_mail(
"Kolibri Studio storage request",
f"Kolibri Studio storage request from {self.request.user}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishekzod007 This change is unrelated to the issue referenced in the PR description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a mistake by me

@Abhishekzod007
Copy link
Contributor Author

@bjester please review

@Abhishekzod007
Copy link
Contributor Author

Hii @bjester , I done the changes that you told me to do. I have push the changes in the PR.
Please tell me is it enough or something else I have to do.

@bjester
Copy link
Member

bjester commented Mar 12, 2024

@Abhishekzod007 This looks good, but with one linting issue below. I still see the change for #4418 included here, but since you've now been assigned, we can include that here and close the issue when you complete the unit test.

There's one linting error:

contentcuration/contentcuration/frontend/shared/views/ResizableNavigationDrawer.vue
Error:   40:7  error  Prop 'defaultWidth' requires default value to be set  vue/require-default-prop

https://github.com/learningequality/studio/actions/runs/8224272224/job/22575306609?pr=4436#step:6:28

@Abhishekzod007
Copy link
Contributor Author

Hi @bjester,I have fixed the linting issue, thanks

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjester bjester merged commit 5c0d00a into learningequality:unstable Mar 12, 2024
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button text cut off in Edit Modal/crowding of sidebar
3 participants