-
Notifications
You must be signed in to change notification settings - Fork 228
Patch navbarwidth #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch navbarwidth #4436
Conversation
Hii @bjester , can you please review it?. So that I'll have better idea, if I have to work more on this or it is enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhishekzod007 I left some comments on your solution here
|
||
send_mail( | ||
"Kolibri Studio storage request", | ||
f"Kolibri Studio storage request from {self.request.user}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhishekzod007 This change is unrelated to the issue referenced in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was a mistake by me
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
89eb121
to
cc2828a
Compare
@bjester please review |
Hii @bjester , I done the changes that you told me to do. I have push the changes in the PR. |
@Abhishekzod007 This looks good, but with one linting issue below. I still see the change for #4418 included here, but since you've now been assigned, we can include that here and close the issue when you complete the unit test. There's one linting error:
|
Hi @bjester,I have fixed the linting issue, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Abhishekzod007
Summary
Description of the change(s) you made
Firstly I found out the position where that particular file is located and it took a lot of time to find and then did some changes there by putting and deleting values so that I can check updates on the actual website. This is an attempt to solve issue #4171
Manual verification steps performed
Reviewer guidance
I have only changed the value of that particular width.
References
Closes #4171
Includes update for #4418 (minus tests TBC)
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)