Improve discovery of preview in kolibri for guest users #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contentcuration/contentcuration/frontend/channelList/views/Channel/ChannelItem.vue
Outdated
Show resolved
Hide resolved
…available as guest user
ozer550
force-pushed
the
improve-discovery-of-preview-in-kolibri-for-guest-users
branch
from
fd55b85 to
4ef719a
Compare
rtibbles
reviewed
May 14, 2025
| /> | ||
| <ChannelStar | ||
| v-if="loggedIn" | ||
| :channelId="channelId" | ||
| :bookmark="channel.bookmark" | ||
| class="mr-1" | ||
| /> | ||
| <BaseMenu v-if="showOptions"> | ||
|
|
||
| <BaseMenu v-if="iconConfigs.find(config => config.key === 'kebab-menu')?.show"> |
There was a problem hiding this comment.
Flagging that we can't use the conditional chaining operator in vue templates at the moment - so will need to tweak this - can move to a computed prop if that's easier.
This should fix the test failures.
rtibbles
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Seeing two discrepancies between my testing and the videos. Firstly, when logged in as an admin, I am still seeing the details buttons in the cards, which is not what was showing in the video:
Secondly, when I click on the "Go to source website" button - nothing happens. Demo URLs work fine, but not the source website button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
changes1.mp4
changes2.mp4
References
closes #3083
Reviewer guidance