Skip to content

Ensure that file_format and preset match during file_upload requests. #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Ensure that file_format and preset match during file_upload requests. #5040

merged 1 commit into from
Aug 13, 2025
+35 −0

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 1, 2025

Summary

  • Adds a small validation check to file uploads to ensure that we don't allow uploads of files with mismatched file formats and format presets
  • Adds/updates tests for the same

@rtibbles rtibbles mentioned this pull request May 1, 2025
Closed
bjester
bjester approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit c332afa into learningequality:unstable Aug 13, 2025
13 checks passed
@bjester bjester mentioned this pull request Aug 14, 2025
Merged
@bjester bjester mentioned this pull request Aug 22, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester bjester approved these changes

Assignees

@ozer550 ozer550

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtibbles @bjester @ozer550