Skip to content

Confirm None handling for attribution fields. #5104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

rtibbles
Copy link
Member

Summary

Adds a regression test to confirm the previously applied fix for #4073

References

Fixes #4073

Reviewer guidance

The underlying behaviour is already fixed, so this is just a regression test for the fix itself.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
rtibbles Richard Tibbles
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me!

@AlexVelezLl AlexVelezLl merged commit 1e4aa8e into learningequality:unstable Aug 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle null model fields when iterating
2 participants