Updated the license info section to use the KExternalLink component for license URLs #5107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
reviewed
Jun 16, 2025
There was a problem hiding this comment.
Thanks @yeshwanth235, only two small tweaks and we can merge!
(as a follow-up, I'm just preparing a KDS issue to make external links behave better regarding margins)
contentcuration/contentcuration/frontend/settings/pages/Storage/RequestForm.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/settings/pages/Storage/RequestForm.vue
Show resolved
Hide resolved
yeshwanth235
changed the title
MisRob
requested changes
Jun 19, 2025
|
Update the PR |
MisRob
approved these changes
Jun 19, 2025
Follow-up issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the license info section to use the KExternalLink component for license URLs
Screen shot
References
Fixes #5092
Reviewer guidance
Areas to test
Learn More links in Settings > Storage > 'Request more space' form > 'About licenses' modal