Skip to content

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Jun 13, 2025

Summary

Upgrades KDS from 5.0.0 through 5.0.1, 5.0.2, 5.1.0 to 5.2.0.

Related release notes

References

This will unblock #5064

Comments

I've located these KCardGrid updates as the only change to check on in Studio:

Screenshot from 2025-06-13 07-27-05

Theoretically, neither of them should require any Studio updates since

  • Gap update will decrease grid gap size from 30px to 24px which designers consider best suitable and in most cases, Studio included, we want to use the new default 24px.
  • syncCardsMetrics update fixes a bug and shouldn't cause any regressions

However, t'd be good to at least preview the card grid in search recommendations. How do we review visual changes to search recommendations on unstable? @akolson is there a simple way to preview, or perhaps at least mock data you could share with me with recommendation where to put them?

Reviewer guidance

Have you noticed any other areas in release notes that we should check on?

@akolson
Copy link
Member

akolson commented Jun 16, 2025

@akolson is there a simple way to preview, or perhaps at least mock data you could share with me with recommendation where to put them?

@MisRob I think at the best way to preview would be to use the unstable version of studio. I'll proceed to approve the merge so the changes can be deployed.

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MisRob

@akolson akolson merged commit 4534959 into learningequality:unstable Jun 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants