-
Notifications
You must be signed in to change notification settings - Fork 224
feat(texteditor): completely replace old with new TipTap editor 🎉 #5246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(texteditor): completely replace old with new TipTap editor 🎉 #5246
Conversation
8c702b4
to
ffc5736
Compare
Hi @habibayman - amazing work on this! It's so exciting to see the new text editor in place. I can see that Misha has added some comments for you regarding optimizations and I know you'll be looking into that for your next PR. I still have some code review to do -- so far my comments are just about some UX things that I think we could improve (and I think they make the most sense to include in this PR) before Radina starts QA, since we've already "found" them.
Screen.Recording.2025-08-13.at.10.16.40.AM.mov
Screen.Recording.2025-08-13.at.10.20.04.AM.mov
I think this would be worth raising for conversation in #studio-dev, to think about where we may want to call this validation that is more relevant and efficient. Screen.Recording.2025-08-13.at.10.23.51.AM.mov
Screen.Recording.2025-08-13.at.10.27.48.AM.mov |
Hi @marcellamaki Thanks!
![]()
|
I fixed the main problem which is not being able to open questions/answers for keyboard/screen reader users. tab-to-question.webmtab-to-answer.webmThere're still few weird behaviors of how the focus flow goes in the exercise editor in general, I used a browser extension to test that 😅 I just don't think they fit in this PR since I will not be editing anything related to the editor. But yes I would like to work on this I don't mind that. I'd like to coordinate that with Radina first before opening a separate issue :)
when I tried it, it did get included, just after you've gone over all the answers/hints in the section, and that's what I meant with "weird behavior" that we need to decide on :) |
eb07cfe
to
e46709e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking feedback has been addressed. Between the other open PRs for optimizations, plus looking forward to Radina's QA for follow up tasks and further refinement, this is ready to get merged 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
Great work, @habibayman 👏
Summary
This PR includes integrating the editor where it should be in studio & removing all traces of the old editor which includes:
contentcuration/contentcuration/frontend/shared/views/MarkdownEditor/
folderThe specs for fitting the new editor also included some changes to the exercise editing UI, mainly to allow for more place to fit the editor.
Note
I added a new functionality that wasn't in the old editor but in my opinion makes sense to be there, I can use your opinion on this.
The functionality is: minimizing the editor on click outside, not just on the click of the minimize icon
Important
This branch has a dependency on 2 PRs and should be rebased once mergedDONEReferences
currently this PR represents part of Update rich text editor to flexible, extensible rich text editing framework #5049
fixes [New Rich Text Editor]: Completely replace the old editor #5206
Studio UI figma design
Reviewer guidance
Try a full editing experience with no constraints this time 😃
Uploader
component inAssessmentItemEditor.vue
is now of no use, I have removed it in PR #5271 : a18f114