Improve query that checks storage space before channel deploy #5248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduced the complexity of the query slightly by using an
EXISTS
clause instead ofIN
. In explaining the query, the runtime was cut in half and it appears the query plan is slightly better by avoiding hash buckets. It also seems that a runtime decision is made to further improve the query over its chosen plan, as it(never executed)
a portion of the query, which gives further confidence the query planner has enough flexibility to chose a quicker execution plan.Additionally, some semi-related storage calculation methods were marked as deprecated, as well as the endpoint where they're used, their only usage and a no longer used API by ricecooker.
References
closes #5069
Reviewer guidance