Skip to content

Conversation

bjester
Copy link
Member

@bjester bjester commented Aug 28, 2025

Summary

Re-adds module replacement in the webpack config for Vuetify's stylus files, but more specifically only targeting .styl files. Without this specificity, other resolution failures occur for mini-css-extract-plugin/dist/hmr/hotModuleReplacement.js, which was the original cause for removal during the pnpm transition.

image

References

source #4106
closes #5342

Reviewer guidance

  1. Edit the webpack config to always use the devserver output path
  2. Run npx webpack serve --env prod --config webpack.config.js --progress and pnpm run runserver
  3. Check studio UI for RTL lang

@rtibbles rtibbles self-assigned this Aug 28, 2025
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out. I can't for the life of me remember how this works, but hopefully we'll just get rid of Vuetify and I'll never have to remember!

@rtibbles rtibbles merged commit 70f3152 into learningequality:hotfixes Aug 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants