Show notification when Mypy exits abnormally #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when mypy failed for some reason (some cases of invalid configuration, bugs in plugins of mypy, etc), the errors were hidden and no inspections would appear in IDE. This is bad because it may make buggy Python code look correct. Now a notification appears with content from mypy stderr output.
intgr
force-pushed
the
report-mypy-failures
branch
from
5192db9 to
adbce30
Compare
leinardi
approved these changes
Feb 21, 2022
leinardi
reviewed
Feb 26, 2022
| @@ -50,6 +50,7 @@ plugin.notification.unable-to-run-mypy.subtitle=Unable to run Mypy | |||
| plugin.notification.unable-to-run-mypy.content=Mypy is installed inside the project environment but the plugin \ | |||
| is not able to run it. If you just installed it try to run File -> Synchronize or restart your IDE. \ | |||
| If the problem persists you may need to manually enter the path to the Mypy executable inside the Plugin settings. | |||
| plugin.notification.abnormal-exit.subtitle=Mypy exited abormally | |||
There was a problem hiding this comment.
There was a typo on the word abnormally (abormally). I fixed it and already pushed on master.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
masterbranch (and not thereleasebranch)using the
Fixes #1234syntaxDescription
Before this change, when mypy failed for some reason (some cases of invalid configuration, bugs in plugins of mypy, etc), the errors were hidden and no inspections would appear in IDE. This is bad because it may make buggy Python code look correct.
Now the following notification appears (the content is verbatim from mypy stderr output)
Type of Changes
Related Issue
Closes #60 -- or at least should help pinpointing the issue to get a better bug report.