If on edge, bounce (w/ TypeScript changes) #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ans. Also, inverted Y-axis logic because the code copied from the Scratch VM does not take into account the y-axis difference between Scratch VM and Leopard.
…e edge detection.
…ing unnecessary no-op math as pointed out by @towerofnix.
towerofnix
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Looks good! This was pretty heavily battle-tested throughout #114 and all the code comments from them were later cleaned up too; we also just tested a side-by-side with this project and it's almost spot-on with Scratch. Thanks @HanClinto and @adroitwhiz!!
I opened leopard-js/sb-edit#127 to be merged alongside this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #120, merge alongside or before leopard-js/sb-edit#127.
This is #114 with the TypeScript changes merged.