-
Notifications
You must be signed in to change notification settings - Fork 30
Add support for when backdrop switches to block #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping contribute to scratch-js, @apple502j! I really appreciate what you're doing. 😄
I've requested a few changes to this PR. One of them is super minor, and the other is to keep each PR to just one change at a time (and to preserve a decision that we made in the past and with which I am quite content).
Again, thank you for your efforts!
@PullJosh force-pushed the change, thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just formatting issues now. Thanks again for your contribution! 😄
Is there any possibility this PR can be merged? I would realy like to have support for "when backdrop switches to" block... |
It'll have to be rebased. |
This will come in handy once we implement "switch backdrop and wait"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavior looks good to me. 👍
This adds support for "when backdrop switches to" block. (example project uses it!) This also changes costume setter to check the sprite type (stage/normal sprite) so that you can't use
next costume
in stage, and removesrandom costume
because it's not used in scratch-vm.