Skip to content

Conversation

apple502j
Copy link
Contributor

This adds support for "when backdrop switches to" block. (example project uses it!) This also changes costume setter to check the sprite type (stage/normal sprite) so that you can't use next costume in stage, and removes random costume because it's not used in scratch-vm.

Copy link
Collaborator

@PullJosh PullJosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping contribute to scratch-js, @apple502j! I really appreciate what you're doing. 😄

I've requested a few changes to this PR. One of them is super minor, and the other is to keep each PR to just one change at a time (and to preserve a decision that we made in the past and with which I am quite content).

Again, thank you for your efforts!

@apple502j
Copy link
Contributor Author

@PullJosh force-pushed the change, thanks for reviewing!

Copy link
Collaborator

@PullJosh PullJosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just formatting issues now. Thanks again for your contribution! 😄

@reinertd
Copy link

Is there any possibility this PR can be merged?

I would realy like to have support for "when backdrop switches to" block...

@adroitwhiz
Copy link
Collaborator

It'll have to be rebased.

This will come in handy once we implement "switch backdrop and wait"
Copy link
Collaborator

@PullJosh PullJosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior looks good to me. 👍

@adroitwhiz adroitwhiz merged commit c132c6d into leopard-js:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants