-
-
Notifications
You must be signed in to change notification settings - Fork 28
Upgrade React Native from 0.70.6 to 0.71.0-rc.5 #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leotm
merged 32 commits into
master
from
react-native-upgrade-from-0.70.6-to-0.71.0-rc.5
Dec 22, 2022
Merged
Upgrade React Native from 0.70.6 to 0.71.0-rc.5 #1316
leotm
merged 32 commits into
master
from
react-native-upgrade-from-0.70.6-to-0.71.0-rc.5
Dec 22, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4b2d1b.
Since building via Gradle Wrapper not RN CLI
mergeDexRelease should succeed via Gradle Wrapper
- ubuntu-latest (same) - gradle/[email protected] (downgrade)
646f6ef
to
6c6791f
Compare
* What went wrong: Execution failed for task ':app:mergeDexRelease'. > A failure occurred while executing com.android.build.gradle.internal.tasks.DexMergingTaskDelegate > There was a failure while executing work items > A failure occurred while executing com.android.build.gradle.internal.tasks.DexMergingWorkAction > com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives: Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes. Type com.facebook.react.viewmanagers.ActivityIndicatorViewManagerInterface is defined multiple times: /home/runner/work/react-native-template-new-architecture/react-native-template-new-architecture/android/app/build/intermediates/project_dex_archive/release/out/com/facebook/react/viewmanagers/ActivityIndicatorViewManagerInterface.dex, /home/runner/work/react-native-template-new-architecture/react-native-template-new-architecture/android/app/build/intermediates/external_libs_dex/release/mergeExtDexRelease/classes.dex
…e-from-0.70.6-to-0.71.0-rc.5
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deps
Normal dependencies needed at runtime
priority: high
react native
react-native-community.github.io/upgrade-helper
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed until rdy2go (details: #1133)
Issues
cmake_minimum_required
3.18.1 #1164PRs
Locally: JDK 19 + Gradle 7.6 + RN CLI ✅ Gradle Wrapper ❌
CI: JDK 18 + Gradle 7.6 + Gradle Wrapper ❌
Local (left) CI (right)
nb
nb: gradle-7.5.1 only officially supports Java 18
...
fixed cause in 442fb86 affecting
also then affected by JDK 18/19 +/- Gradle 7.5.1/7.6