Partition Manager Review #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This moves from the -E to -X XML-based CLI and parses it
This removes any dependnecy on the auto-increment value, as AI can only tell us a single column's position, and for multi-column partitions we'll need more than that. This change does not totally remove the get_autoincrement method, as we'll still want to confirm the table has the partitioned feature, which we'll do in a next commit.
Removes the auto_incremennt mechanisms.
This adds the necessary retention options for later command processing, which is not included in this commit.
There are other BY RANGE options too, but let's just start with COLUMNS
…e Maintain algo The README.md expresses the "Maintain" algorithm in its ideal form, which got messy in implementation. The get_pending_sql_reorganize_partition_commands makes that clean again, so that there's a clear map to the algorithm description.
jcjones
reviewed
Jul 23, 2021
tgeoghegan
reviewed
Aug 4, 2021
beautifulentropy
requested changes
Aug 4, 2021
In the real world, we might mess up when naming a partition. This should be rare if partitionmanager is running often, since it'll rename partitions to match reality, but when it's running only rarely, things get out of date. This change avoids attempting to calculate rates-of-change using partitions that don't make sense - e.g., today is July 1, and our active partition says it starts in a week. That is plainly wrong, but we can still use our current rate-of-change.
Co-authored-by: Tim Geoghegan <[email protected]>
Co-authored-by: Samantha <[email protected]> Co-authored-by: Tim Geoghegan <[email protected]>
This was referenced Aug 18, 2021
Closed
Co-authored-by: Samantha <[email protected]>
Co-authored-by: Samantha <[email protected]>
Co-authored-by: Tim Geoghegan <[email protected]>
|
Closed by 51e10be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists for the purpose of allowing folks an easy way to provide
file- and line-specific comments.
The base branch (
pr-base) consists of a single empty commit.The PR branch (
pr-branch) consists of the entire history of themainbranch, rebased on top of
pr-base. This convinces GitHub to allow usto create a reviewable PR.
DO NOT SUBMIT, it wouldn't do any good, this code is all in main already.