Skip to content

Conversation

Tasssadar
Copy link

@Tasssadar Tasssadar commented Jun 16, 2021

Adds support for the certificate revocation mechanism via CRL. I have tried to mimic what libpq does when verifying CRL. Revocation logic in Go inspired by https://github.com/cloudflare/cfssl/blob/master/revoke/revoke.go#L139

I'm willing to write tests for this, but I need the private key of pq CA to generate the testing CRLs :/

@maddyblue
Copy link
Collaborator

https://github.com/lib/pq/tree/master/certs might have that key

@Tasssadar
Copy link
Author

https://github.com/lib/pq/tree/master/certs might have that key

There are only the leaf cert private keys there, the CA private key (C=US, ST=Nevada, L=Las Vegas, O=github.com/lib/pq, CN=pq CA) is needed to generate CRL.

@otan
Copy link
Collaborator

otan commented Nov 7, 2021

You can recreate the keys if you want from scratch, just make sure you change them in CI as well.
See: #1054
Maybe we should commit the private keys this time :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants