fix: modify COPY prepare handling to use internal utility #1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updated the handling of the
COPY
statement in the Prepare function to utilize theinternal.StartsWithCOPY
utility to detect if a query is aCOPY
statement even if it has comments or whitespaces.Motivation
Our
Datadog/dd-trace-go
library supports instrumentingdatabase/sql
, including the DBM-APM link based onSQLcommenter
spec, with the difference that we are prepending the comment instead of appending it. This breaks howlib/pq
detects aCOPY
statement.We are aware that there were previous opened issues around
COPY
statements, but we feel this one is an improvement, as SQL comments are not uncommon in the wild. Also, it's the only place where this kind of check happen inlib/pq
.This would fix #1154, although it might break the workaround described in #530. We didn't attempt to address the concerns explained in #213.
Benchmarks
Although it's almost eight times slower at the nanoseconds scale, it should negligible in the context of preparing a query.