Reduce garbage produced every update #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache ControllerButton.values() and ControllerAxis.values() to prevent creating garbage also axis values are no longer boxed into Float objects every update
Tom-Ski
reviewed
Jun 24, 2023
...rs-desktop/src/main/java/com/badlogic/gdx/controllers/desktop/support/JamepadController.java
Show resolved
Hide resolved
...rs-desktop/src/main/java/com/badlogic/gdx/controllers/desktop/support/JamepadController.java
Show resolved
Hide resolved
| @@ -164,7 +167,7 @@ private void updateButtonsState() { | |||
|
|
|||
| private void initializeState() { | |||
| for (ControllerAxis axis : ControllerAxis.values()) { | |||
There was a problem hiding this comment.
I know this is only called once, but is there a reason this does not use CONTROLLER_AXIS_VALUES?
There was a problem hiding this comment.
Exactly, I was only concerned with the update method. Since this is only called once, it doesn't matter here. I'll happily change it to what you prefer.
There was a problem hiding this comment.
I think it is better to use the new constant, otherwise code readers may ask why it is used only at some places.
There was a problem hiding this comment.
Alright. Won't get to it this weekend, but will implement the changes after the weekend.
also use the constants instead of ControllerButton.values() consistently throughout the file
|
Forgot about this one, sorry, but finally made the changes. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, after some profiling found that this library produces quite some garbage every frame/update.
ControllerButton.values()andControllerAxis.values()for the update methods, since those were creating new arrays all the time. (some JVMs might be able to correctly optimize this, but the one I profiled did not)axisState.put(id, value);was causing the values to be boxed to newFloats every update, so I introduced a simple wrapper class with a mutable float, which does not create any garbageThis only covers the desktop version, similar optimizations could be made for other platforms probably.
IDK if this can be merged as-is, but would love to hear about any suggestions or doubts.