Fold git_push_unpack_ok() into git_push_finish()
#2756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The push cannot be successful if we sent a bad packfile. We should return an error in that case instead of storing it elsewhere.
This should make it clearer what the return value implies.
|
Yeah, I think this clarifies things a lot. |
ethomson
added a commit
that referenced
this pull request
Dec 10, 2014
Fold `git_push_unpack_ok()` into `git_push_finish()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #2628 fold the
unpack_ok()error intofinish()as we shouldn't have a successful return code if we sent a bad packfile or the server errored out.This also updates the documentation to hopefully better explain what the function's error reporting is about.