This repository was archived by the owner on Jun 26, 2023. It is now read-only.
feat: async peer store #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors interfaces and classes used by `libp2p-interfaces` to use the async peer store from libp2p/js-libp2p#1058
7 tasks
| }) | ||
|
|
||
| // 'change:protocols' event handler is async | ||
| await delay(10) |
There was a problem hiding this comment.
why not listen for the event?
There was a problem hiding this comment.
The hander that invokes topology._updatePeers is async, so we can't just listen for the event as we're interested in the side-effects of the handler being invoked.
From a practical perspective the mock peer store used in the tests doesn't really do any async work, it just defers execution using the async keyword so delay here puts the rest of the test into the microtask queue - the handler is ahead of it in the same queue so this is enough for the test to pass.
Longer term we shouldn't test for side-effects like this as it's really fragile and makes refactoring hard.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors interfaces and classes used by
libp2p-interfacesto use the async peer store from libp2p/js-libp2p#1058BREAKING CHANGE: peerstore methods are now all async