Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Conversation

maschad
Copy link
Member

@maschad maschad commented Feb 4, 2023

In order to avoid creating wrapper functions to extract a map of the connections from a default ConnectionManager implementation (as mentioned in libp2p/js-libp2p#1567) , we should allow that field to be made accessible.

Now whilst the getConnections function could achieve this, it adds additional runtime logic which coulda affect performance.

@maschad maschad requested a review from achingbrain February 4, 2023 02:41
@maschad maschad marked this pull request as draft February 6, 2023 18:32
@maschad maschad marked this pull request as ready for review February 6, 2023 19:35
@achingbrain
Copy link
Member

In order to merge this as a feature and not a breaking change a PR needs to be opened against libp2p that adds the new methods to the default connection manager. This change then needs to ship before this PR can be merged.

@maschad
Copy link
Member Author

maschad commented Feb 17, 2023

Since libp2p/js-libp2p#1586 has been merged this can be reviewed now @achingbrain

@maschad maschad marked this pull request as draft February 22, 2023 21:21
@maschad maschad changed the title feat: added method to get the map of connections feat: Update Connection Manager and Dialler Configs. Feb 22, 2023
@maschad
Copy link
Member Author

maschad commented Feb 22, 2023

In light of the work being done on libp2p/js-libp2p#1581 I have made some more updates that will be required for libp2p/js-libp2p#1594

@maschad maschad marked this pull request as ready for review February 22, 2023 22:03
@maschad maschad requested a review from wemeetagain February 22, 2023 22:03
@maschad maschad changed the title feat: Update Connection Manager and Dialler Configs. feat: Update Connection Manager and Dialler Interfaces and Configs. Feb 22, 2023
@achingbrain achingbrain marked this pull request as draft March 28, 2023 15:53
@maschad
Copy link
Member Author

maschad commented Apr 25, 2023

This is no longer necessary since the refactor of the connection manager in libp2p/js-libp2p#1678 in tandem with the changes being added in libp2p/js-libp2p#1563

@maschad maschad closed this Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants