Can't use libp2p-websocket-star with libp2p version from and after 0.21.0

[ajayrao80]

Version: libp2p 0.23.1
libp2p-websocket-star 0.8.1
node js version 10.0

Platform: Windows 10, 64 bit

const libp2p = require("libp2p")
const Id = require("peer-id")
const Info = require("peer-info")
const multiaddr = require("multiaddr")
const pull = require('pull-stream')

const WSStar = require('libp2p-websocket-star')

Id.create((err, id) => {
  if (err) throw err

  const peerInfo = new Info(id)
  peerInfo.multiaddrs.add(multiaddr("/dns4/ws-star-signal-1.servep2p.com/tcp/443/wss/p2p-websocket-star/"))

  const ws = new WSStar({ id: id }) // the id is required for the crypto challenge

  const modules = {
    transport: [
      ws
    ],
    discovery: [
      ws.discovery
    ]
  }

  const node = new libp2p(modules, peerInfo)
})

Above code throws an error:
`

ValidationError: {
  "transport": [
    {
      "id": {
        "id": "QmctgFJRRvERtVie5qMUgsQtEySL4QaUbg1wXq3UXBRDCE",
        "privKey": "CAASpgkwggSiAgEAAoIBAQCgaSSCw/GwYbwst6zG+PquQBvJ1O9IYX8pDB/R8otpBk7g+SWK/kZMSX0SRPpCOsy0+wp7IKeK1KHagzk9fzwUnShym463WxP6rUsdM74u6q8t/0Cmfz+Z6ODS5nfIzCMUH4syUOuDvjpD4mgr3Ihl9Fl3sga+jdHpQTkBisjk1nqE1L2TJQCZ1aWhpSarRT1FKLmKs9JsgRL0cyGLkV7MGkCc4SUJHltyiHnkRPePA+oMZ4McnETPpDnwlNHpg4t4PUeocpI9w5r+YrxVJweM1N+DjxleOHvWiUsbUT+ujMvnvidAl5dE88ITsL5mDDuEvRj0mTrZzpIcsK96PtoDAgMBAAECggEATlstz4aBb+Q99CYAiu0iHq4IJO4TuGqPn/BhNr/go3vGWhS55wxQMIGRS7RP/rwUNK+QLhcEYEd/jGqfMlANfBBMqrcb3qrptoCh+XDGDMrsqW5PGUV9PuRHth2IE5jL5c+GwhxO/vqUIYbd1dcS9aKHdXWL39cM24DVpNAzU7w8kJV1qlU6zrz4t/7HK0gwQ5d0L3mINoausSWAVNPVF3PDtb7IP1Lp1KexDGkBrOfBLyW8iAm31dlcsMyGF+0mJoVc5US6R87tkqQh+8SvVAhYwBbs0pTjjBhuyDDCsVHb/AGNKKrGyU1vOwOpIkYIj16epZYOSpEbO1TjBl4Z+QKBgQDtDCQPP1GRHe0TDk/cKRcMUAqccns0hhVTqENBxVqJ4Tfd54TmrTgINEC9meuUF+LmFjzXE20issZ8h88uYfN7lR4Moz+eIC0IZJn56D4eXQn/iseXEyzyg31oaFHewLrNjRFFQoASxzTPLtJ/rCHNUIXID7JGhqUZ5bibRrdlpQKBgQCtPGkTeNXyAdsYKVkm9Fjhq+TFTo2oIKFMvM3ACmCPNSKjX8Rksc65u6xQIjBlgVZefFAVWM5HEbeVQ6hKpF13S7s8X+zZg5vrYEgsuh8ACSF7P80TTVvCQN62fwW4kp70tATMOUCZ6fK7Q9ivpBE5W7PdgeOGVy5hlqIcaXNAhwKBgCJVI9Phg9rUzsV3yTFF8kSiQyctnZKZ6PTY5gTcpKRbrk/BfIo8hGULzGSpqmkknIRerCkqcyAXbJAUy3kYTr+TdWq3KjuoxVz11SdQ785OA2iznPzQli35xWwdz93HZEbpK5swaoRNveRUD8DWGX83LmkvfM6iKb96eiZjM6TRAoGATXcoHZb5RMDjskg7H5pAbJmrMTfRTI9a0a/T6b46M4+1L41Rix2frZpokWTYc2uErbe1L/aIN2uKxmp8xPP+/6uTzImwpgueG4DwhV+tIRz0JeL/11POZm0PqlfevQyDnDUruA8Z/jmJW4gZS2F4ekexhKnijl5J1UXAtCfLa90CgYBQv1fcW4MNtrUH+efCSDCPg5lXyWalhXBCQaFxPEkqHZxFKpTUEpcOItrT86JxtPmCS2nBHcSnyPnnGBxEWU3Vel95/dTPCeUUteUGJxSWrX/qHkWV3bouglolIHhROJlbtE5a4ntrYHnLZVL+zMYpDt3FhE4zbZ1F3gzDKplpgA==",
        "pubKey": "CAASpgIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCgaSSCw/GwYbwst6zG+PquQBvJ1O9IYX8pDB/R8otpBk7g+SWK/kZMSX0SRPpCOsy0+wp7IKeK1KHagzk9fzwUnShym463WxP6rUsdM74u6q8t/0Cmfz+Z6ODS5nfIzCMUH4syUOuDvjpD4mgr3Ihl9Fl3sga+jdHpQTkBisjk1nqE1L2TJQCZ1aWhpSarRT1FKLmKs9JsgRL0cyGLkV7MGkCc4SUJHltyiHnkRPePA+oMZ4McnETPpDnwlNHpg4t4PUeocpI9w5r+YrxVJweM1N+DjxleOHvWiUsbUT+ujMvnvidAl5dE88ITsL5mDDuEvRj0mTrZzpIcsK96PtoDAgMBAAE="
      },
      "discovery": {
        "_events": {},
        "_eventsCount": 0,
        "tag": "websocketStar",
        "start": (callback) => {\n      setImmediate(callback)\n    },
        "stop": (callback) => {\n      setImmediate(callback)\n    }
      },
      "listeners_list": {},
      "_peerDiscovered": function () { [native code] }
    }
  ],
  "discovery": [
    {
      "_events": {},
      "_eventsCount": 0,
      "tag": "websocketStar",
      "start": (callback) => {\n      setImmediate(callback)\n    },
      "stop": (callback) => {\n      setImmediate(callback)\n    }
    }
  ],
  "peerInfo" [1]: -- missing --
}

[1] "peerInfo" is required
    at Object.exports.process (F:\classwork\madnet\node_modules\joi\lib\errors.js:196:19)
    at internals.Object._validateWithOptions (F:\classwork\madnet\node_modules\joi\lib\types\any\index.js:675:31)
    at module.exports.internals.Any.root.validate (F:\classwork\madnet\node_modules\joi\lib\index.js:138:23)
    at module.exports.internals.Any.root.attempt (F:\classwork\madnet\node_modules\joi\lib\index.js:167:29)
    at module.exports.validate (F:\classwork\madnet\node_modules\libp2p\src\config.js:42:17)
    at new Node (F:\classwork\madnet\node_modules\libp2p\src\index.js:32:16)
    at Id.create (F:\classwork\madnet\sumne.js:27:16)
    at waterfall (F:\classwork\madnet\node_modules\peer-id\src\index.js:156:5)
    at F:\classwork\madnet\node_modules\async\internal\once.js:12:16
    at next (F:\classwork\madnet\node_modules\async\waterfall.js:21:29)

`

Severity: Critical

Description:

Using libp2p-websocket-star with latest libp2p throws an error of "'peerInfo' is required".

Steps to reproduce the error: Run the above code with libp2p (version : 0.21.0 - 0.23.1) and libp2p-websocket-star (0.8.1) installed.

[jacobheun]

Hi @ajayrao80 with 0.21.0 there was a breaking change for the libp2p constructor, it now only takes a single argument, options.

You will need to change

const node = new libp2p(modules, peerInfo)

to

const node = new libp2p({
  modules, 
  peerInfo
})

This should resolve the validation error issue. The readme and examples folder have been updated for the latest usage.

[ajayrao80]

Thanks. That worked