fix: when passed a multiaddr, only dial that multiaddr #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user passes a multiaddr to `libp2p.dial`, only dial that multiaddr instead of extracting the peer id from the multiaddr, using it to look up every known address and dialing them all. When passing a peer id to `libp2p.dial`, all addresses will be dialed as before. Fixes #1497
mpetrunic
reviewed
Nov 28, 2022
mpetrunic
approved these changes
Nov 30, 2022
This was referenced Dec 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user passes a multiaddr to
libp2p.dial, only dial that multiaddr instead of extracting the peer id from the multiaddr, using it to look up every known address and dialing them all.When passing a peer id to
libp2p.dial, all addresses will be dialed as before.Fixes #1497