Skip to content

Latest wrtc is breaking support in Node.js #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 12, 2018
Merged

Latest wrtc is breaking support in Node.js #193

merged 5 commits into from
May 12, 2018

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented May 12, 2018 •
edited
Loading

ref #191

@ghost ghost assigned daviddias May 12, 2018
@ghost ghost added the status/in-progress In progress label May 12, 2018
@daviddias
Copy link
Member Author

daviddias commented May 12, 2018 •
edited
Loading

Seems that wrtc is causing issues

image

Tests in Node.js fail, in Browser they pass.

@daviddias
Copy link
Member Author

daviddias commented May 12, 2018 •
edited
Loading

I can reproduce a similar error coming by using the latest wrtc. It seems it is mangling the data. See:

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) exp/wizard Extensive knowledge (implications, ramifications) required P1 High: Likely tackled by core team if no one steps up labels May 12, 2018
@daviddias daviddias changed the title Testing what's up with CI Latest wrtc is breaking support in Node.js May 12, 2018
@daviddias
Copy link
Member Author

Breaking was introduced on 0.1.2. Only 0.1.1 works.

@daviddias daviddias mentioned this pull request May 12, 2018
Closed
@daviddias
Copy link
Member Author

locking v to 0.1.1 for now. Reported at #194 to be debugged in async

@daviddias
Copy link
Member Author

image

no mac os x workers :(

@daviddias daviddias merged commit 6507379 into master May 12, 2018
@daviddias daviddias deleted the check-tests branch May 12, 2018 18:45
@ghost ghost removed the status/in-progress In progress label May 12, 2018
@daviddias daviddias mentioned this pull request May 12, 2018
Closed
@daviddias daviddias mentioned this pull request Jun 20, 2018
Closed
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@dependabot
deps(dev): bump it-all from 1.0.6 to 2.0.0 (libp2p#193)
6213f8f 
Bumps [it-all](https://github.com/achingbrain/it) from 1.0.6 to 2.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/achingbrain/it/releases">it-all's
releases</a>.</em></p>
<blockquote>
<h2>it-all-v2.0.0</h2>
<h2><a
href="https://github.com/achingbrain/it/compare/it-all-v1.0.6...it-all-v2.0.0">it-all-v2.0.0</a>
(2022-10-17)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>all modules are now published as ESM-only</li>
</ul>
<h3>Features</h3>
<ul>
<li>convert to typescript (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/28">#28</a>)
(<a
href="https://github.com/achingbrain/it/commit/f8a38bfb1b902e8101f1077eb33c3cea49819464">f8a38bf</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/achingbrain/it/commit/417a1f3e7cb072a1b199bbe83af65a63ae797815"><code>417a1f3</code></a>
chore(release): 2.0.0 [skip ci]</li>
<li><a
href="https://github.com/achingbrain/it/commit/8bd4bd2d81c9aa26afc809a1478c20a15201a8b6"><code>8bd4bd2</code></a>
chore: update build scripts</li>
<li><a
href="https://github.com/achingbrain/it/commit/585df8dae93fb68a665bc64065366fb2c4add5d3"><code>585df8d</code></a>
docs: update readme</li>
<li><a
href="https://github.com/achingbrain/it/commit/f8a38bfb1b902e8101f1077eb33c3cea49819464"><code>f8a38bf</code></a>
feat!: convert to typescript (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/28">#28</a>)</li>
<li><a
href="https://github.com/achingbrain/it/commit/b621056a11c9bfe991d1040b22a46651fa907a3c"><code>b621056</code></a>
Publish</li>
<li><a
href="https://github.com/achingbrain/it/commit/da0c69f7ab16ddf6dd488cfed5844d1e6fa10366"><code>da0c69f</code></a>
fix: use EventTarget instead of EventEmitter (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/27">#27</a>)</li>
<li><a
href="https://github.com/achingbrain/it/commit/cfc852b428fb0c9ddf3bfbaad26c276b197779f0"><code>cfc852b</code></a>
fix: accepts iterable also (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/24">#24</a>)</li>
<li><a
href="https://github.com/achingbrain/it/commit/c74ff5ff0d1b4164cd2f556f1b431d77ad47dd16"><code>c74ff5f</code></a>
Publish</li>
<li><a
href="https://github.com/achingbrain/it/commit/51221722aa33195fb2f11cf74df9575705706f2b"><code>5122172</code></a>
fix: update types for it-ndjson</li>
<li><a
href="https://github.com/achingbrain/it/commit/9a1ec79746fe9efa8cf8835da3817c427f901dc2"><code>9a1ec79</code></a>
Publish</li>
<li>Additional commits viewable in <a
href="https://github.com/achingbrain/it/compare/[email protected]">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=it-all&package-manager=npm_and_yarn&previous-version=1.0.6&new-version=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 5.0.1 [skip ci]
eb6e2cd 
## [5.0.1](libp2p/js-libp2p-websockets@v5.0.0...v5.0.1) (2022-12-08)

### Bug Fixes

* cannot catch EADDRINUSE ([libp2p#198](libp2p/js-libp2p-websockets#198)) ([c7312db](libp2p/js-libp2p-websockets@c7312db)), closes [libp2p#184](libp2p/js-libp2p-websockets#184)

### Dependencies

* **dev:** bump @libp2p/interface-mocks from 7.1.0 to 8.0.2 ([libp2p#199](libp2p/js-libp2p-websockets#199)) ([daff533](libp2p/js-libp2p-websockets@daff533)), closes [libp2p#318](https://github.com/libp2p/js-libp2p-websockets/issues/318) [libp2p#315](https://github.com/libp2p/js-libp2p-websockets/issues/315) [libp2p#313](https://github.com/libp2p/js-libp2p-websockets/issues/313) [libp2p#312](https://github.com/libp2p/js-libp2p-websockets/issues/312)
* **dev:** bump it-all from 1.0.6 to 2.0.0 ([libp2p#193](libp2p/js-libp2p-websockets#193)) ([6213f8f](libp2p/js-libp2p-websockets@6213f8f)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24)
* **dev:** bump it-drain from 1.0.5 to 2.0.0 ([libp2p#191](libp2p/js-libp2p-websockets#191)) ([e549691](libp2p/js-libp2p-websockets@e549691)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24)
* **dev:** bump it-take from 1.0.2 to 2.0.0 ([libp2p#192](libp2p/js-libp2p-websockets#192)) ([4c037fc](libp2p/js-libp2p-websockets@4c037fc)), closes [libp2p#28](libp2p/js-libp2p-websockets#28)
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@dependabot
deps(dev): bump @libp2p/interface-address-manager from 2.0.5 to 3.0.0 (…
5044392 
…libp2p#193)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
@semantic-release-bot
chore(release): 7.0.4 [skip ci]
e0efcd7 
## [7.0.4](libp2p/js-libp2p-mdns@v7.0.3...v7.0.4) (2023-04-24)

### Dependencies

* **dev:** bump @libp2p/interface-address-manager from 2.0.5 to 3.0.0 ([libp2p#193](libp2p/js-libp2p-mdns#193)) ([5044392](libp2p/js-libp2p-mdns@5044392))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daviddias daviddias

Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daviddias