Skip to content

Conversation

GaluTi
Copy link
Contributor

@GaluTi GaluTi commented May 3, 2024

No description provided.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.63%. Comparing base (86c0a41) to head (80d1754).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   84.82%   82.63%   -2.19%     
==========================================
  Files           9        9              
  Lines        2721     2574     -147     
==========================================
- Hits         2308     2127     -181     
- Misses        413      447      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit
Copy link
Member

hombit commented May 3, 2024

Fixes #356

@hombit hombit linked an issue May 3, 2024 that may be closed by this pull request
@hombit hombit merged commit a8041c7 into master May 3, 2024
@hombit hombit deleted the roms branch May 3, 2024 16:21
Copy link

codspeed-hq bot commented May 3, 2024

CodSpeed Performance Report

Merging #362 will not alter performance

Comparing roms (80d1754) with master (86c0a41)

Summary

✅ 97 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark master roms Change
🆕 test_benchmark_lc_py N/A 718.6 µs N/A
🆕 test_benchmark_rust N/A 464.9 µs N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust implementation of Roms
2 participants