This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Make sure the provided image does not overflow the iOS' metal size. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoccazinsp
changed the title
|
@rodymolenaar any thoughts on this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rodymolenaar I've just discovered that iOS may blow up when given large images, and it will vary from device to device.
On an iPhone 12 pro, the error will be:
Texture Descriptor Validation MTLTextureDescriptor has width (18240) greater than the maximum allowed size of 16384.On an iPhone 7 the value was the same, which is odd, but I guess it depends on a combination of hardware and software.
The fix is to just resize the image if it is too large for the device to handle. The actual metal buffer max size is not constant and not directly exposed to the code, but I grabbed an idea from here https://stackoverflow.com/questions/58366416/how-to-get-programmatically-the-maximum-texture-size-width-and-height which seems to work.
Happy new year by the way!