Implement ExplicitNullaryEtaExpansion #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dwijnand
force-pushed
the
nullary-eta-expansion
branch
from
2e72db5 to
49f324d
Compare
dwijnand
changed the title
This comment has been minimized.
This comment has been minimized.
dwijnand
force-pushed
the
nullary-eta-expansion
branch
from
49f324d to
70eb877
Compare
dwijnand
changed the title
|
All resolved - good to go! |
lrytz
reviewed
Apr 15, 2020
| override def fix(implicit doc: SemanticDocument) = { | ||
| doc.tree.collect { case eta: Term.Eta => | ||
| eta.expr.symbol.info.map(_.signature).collect { | ||
| case MethodSignature(_, Nil, _) => |
There was a problem hiding this comment.
So for nullary methods that override a nilary one, there's no rewrite because the Scala compiler inserts the () parameter list. I guess that's fine, because f _ is allowed in this case.
Scala 2.13.x with -Xsource:3
scala> class C { override def toString = "" }
class C
scala> (new C).toString _
val res2: () => String = $Lambda$989/107279519@60ab895f
Dotty:
scala> class C { override def toString = "" }
// defined class C
scala> (new C).toString _
1 |(new C).toString _
|^^^^^^^^^^^^^^^^^^
|Only function types can be followed by _ but the current expression has type String
scala> class D { override def toString() = "" }
// defined class D
scala> (new D).toString _
val res4: () => String = Lambda$1255/1401633928@19b9f903
There was a problem hiding this comment.
Yeah, but we have no override information in rewrites, so can't do anything about that 😞 (see #14 (comment))
lrytz
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.