Make it explicit witness must conform to MINIMALIF #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
force-pushed
the
2020-04-correct-enforcing-minimalif
branch
from
f4396e2 to
d7a9ecb
Compare
15 tasks
ariard
force-pushed
the
2020-04-correct-enforcing-minimalif
branch
from
d7a9ecb to
060dce8
Compare
|
Updated following 04/13/2020 meeting. |
ariard
force-pushed
the
2020-04-correct-enforcing-minimalif
branch
2 times, most recently
from
78f206d to
e584be9
Compare
cfromknecht
reviewed
Apr 13, 2020
ariard
force-pushed
the
2020-04-correct-enforcing-minimalif
branch
from
e584be9 to
57bd1c8
Compare
cfromknecht
approved these changes
Apr 15, 2020
t-bast
approved these changes
Apr 15, 2020
17 tasks
cdecker
approved these changes
Apr 27, 2020
|
Looks like we have a quorum, merging this and taking it off the agenda for today (yay!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess everyone get it right for its onchain transactions but I found some of my test transactions failing against core so make it explicit spending transaction must conform to MINIMALIF. Currently, it's only a standard rule, not a consensus one. Not conforming transaction will be rejected by core, which can be quite annoying for the timeout case.
If you have a better way to encode this, I will modify.
More context:
bitcoin/bitcoin#8526
https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-August/013014.html