Have the mock log facade not always print to stdout
#510
Conversation
tests/common/logging.rs
Outdated
| @@ -48,6 +48,7 @@ impl LogFacadeLog for MockLogFacadeLogger { | |||
| record.line().unwrap(), | |||
| record.args() | |||
| ); | |||
| #[cfg(ldk_node_test_log_print)] | |||
There was a problem hiding this comment.
isn't the real problem that we have trace level logs as default for tests?
Cant we work with debug level logs for tests?
There was a problem hiding this comment.
I guess we could also consider reducing it, but more generally there is no value in having the MockLogFacadeLogger spamming stdout, as we're really only using it to test our logging interface.
There was a problem hiding this comment.
I think we can reduce the log level and cfg-gate it so it does not clutter stdout.
There was a problem hiding this comment.
Discussed offline. It seems printing is never a good idea because it is not compatible with parallel test running, so probably better to remove completely.
tnull
force-pushed
the
2025-03-test-log-print-cfg
branch
from
f3d9dce to
e5057f5
Compare
|
Rebased to resolve minor conflict. |
In lightningdevkit#463 we introduced a mock logger that implements the `log` facade in tests. Previously, it defaulted to always print `TRACE`-level logs to `stdout`. This however can be very spammy (especially since it includes TRACE-level logs of `electrum_client` now). Here, we simply disable printing to `stdout`
tnull
force-pushed
the
2025-03-test-log-print-cfg
branch
from
e5057f5 to
c5a014f
Compare
|
Pushed fixup that simply drops the |
In #463 we introduced a mock logger that implements the
logfacade in tests. Previously, it defaulted to always printTRACE-level logs tostdout. This however can be very spammy (especially since it includes TRACE-level logs ofelectrum_clientnow).Here, we make printing the log lines optional by
cfg-gating it.(cc @enigbe)