Small tweaks to logging and printing + node_announcement #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
May 5, 2021
jkczyz
reviewed
May 8, 2021
TheBlueMatt
force-pushed
the
main
branch
4 times, most recently
from
1f42069 to
e6682fe
Compare
|
This should be good to go now, modulo squashing fixup commits. |
jkczyz
reviewed
May 10, 2021
src/main.rs
Outdated
Comment on lines
591
to
596
| for chan_info in chan_manager.list_usable_channels() { | ||
| if chan_info.is_public { | ||
| chan_manager.broadcast_node_announcement([0; 3], args.ldk_announced_node_name, | ||
| vec![args.ldk_announced_listen_addr.as_ref().unwrap().clone()]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should this only broadcast once rather than for each public channel?
let has_public_channels = chan_manager
.list_usable_channels()
.iter()
.filter(|chan_info| chan_info.is_public)
.count() > 0;There was a problem hiding this comment.
Oh duh. I'm gonna drop the checks entirely, after upstream/913 we don't need them.
There was a problem hiding this comment.
Just so I understand, when upstream/913 is in this code will be removed entirely?
There was a problem hiding this comment.
No, as in "the extra if statement around chan_info.is_public is moved into broadcast_node_announcement in upstream/913, so we can go ahead and drop it here.
TheBlueMatt
force-pushed
the
main
branch
2 times, most recently
from
12886b7 to
4d4789d
Compare
jkczyz
approved these changes
May 10, 2021
User feedback found `channel_can_send_payments` confusing on its own, and now that we have an upstream `is_confirmed` field, print that. Further, it is useful to have an explicit txid field, even if if is basically duplicative with channel_id.
|
Sorry, somehow I missed that this was squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on lightningdevkit/rust-lightning#912 for the last commit