Error message deserialization/handling

[TheBlueMatt]

We currently drop all error messages, which we (a) shouldn't do (we need to log them) and (b) shouldn't do (need to close the channel referenced in the error message).

[ariard]

For b) you think about all the HandleError with action: None ?
After #91 I think it should be easy to have macro wrapper to log + return.

[TheBlueMatt]

Hmm? for (a) indeed we just need #91 and to log, for (b) we need to pass the message into the ChannelManager and force_close the channel.

[ariard]

You speak about all the HandleError { msg: "Error", action : None } in channel functions post FundingSent ? If so you need a concept of internal error if it's up to ChannelManager to force_close the channel and I'm afraid that block a general scheme for errors we are talking about in #99 . (but maybe i anticipate too much here)

[TheBlueMatt]

I think we're talking about different things here - I'm referring to receiving an Error message on the wire (message type 17) and noting that we need to do two things with it - log it (blocked on #91) and pass the message into the ChannelManager so that it can close the channel. This is wholly separate (I'd think?) from the HandleError/ErrorAction/Event API mess.

[TheBlueMatt]

This was resolved in #131. We also handle Errors we send outbound, but thats #109.