Skip to content

Base32 followups, Features serialization #3308

Open
@optout21

Description

@optout21

Some followups to Base32/Bech32 changes #3270

Bolt11InvoiceFeatures are serialized to 5-bit values internally, but in a way that is not compatible with Bech32. The grouping of bits is done in reverse (both byte order and bit order). The current native implementation could be switch to be based on rust-bech32 (increased reuse), and iterative approach (less allocations). See:
#3270 (comment)

Change fn from_base32(b32: &[Fe32]) to take iterator instead of slice; see #3270 (comment)

Also: (minor) #3270 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions