-
Notifications
You must be signed in to change notification settings - Fork 407
Refactor and Purpose of lightning-net-tokio #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Right, kinda unclear. Having a “import + type one line” way of having a network stack is pretty important imo. Whether it should integrate with tokio...I don’t really know. I think I’d be ok with rewriting it to just have one thread and use mio?
… On Dec 17, 2019, at 15:41, Antoine Riard ***@***.***> wrote:
What the long-term purpose of lightning-net-tokio ? Is it to provide a default networking stack to avoid people writing tricky asynchronous code and in this case is it worthy to maintain ?
We were wondering with @valentinewallace as part of refactoring it to support newer versions of tokio and futures.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Okay, I might try to rewrite it, I need something for testing purpose, but only once we are done with other refactorings |
Fixed in #472. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What the long-term purpose of lightning-net-tokio ? Is it to provide a default networking stack to avoid people writing tricky asynchronous code and in this case is it worthy to maintain ?
We were wondering with @valentinewallace as part of refactoring it to support newer versions of tokio and futures.
The text was updated successfully, but these errors were encountered: