Skip to content

WIP: Drop ChannelManager's ChannelMonitor Arc for reference #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valentinewallace
Copy link
Contributor

@valentinewallace valentinewallace commented Dec 17, 2019

Blocked by #423. Also probs should try to break into multiple commits.

Partially solves #237.

+ drop lightning-net-tokio package in favor of a rewrite.
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #424 into master will increase coverage by 0.17%.
The diff coverage is 99.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   87.49%   87.66%   +0.17%     
==========================================
  Files          30       30              
  Lines       16733    16955     +222     
==========================================
+ Hits        14640    14864     +224     
+ Misses       2093     2091       -2
Impacted Files Coverage Δ
lightning/src/util/test_utils.rs 53.33% <ø> (ø) ⬆️
lightning/src/ln/channelmanager.rs 80.56% <100%> (ø) ⬆️
lightning/src/ln/chanmon_update_fail_tests.rs 97% <100%> (+0.08%) ⬆️
lightning/src/ln/peer_handler.rs 32.83% <100%> (+1.22%) ⬆️
lightning/src/chain/chaininterface.rs 87.38% <100%> (-0.44%) ⬇️
lightning/src/ln/functional_tests.rs 95.83% <100%> (+0.22%) ⬆️
lightning/src/ln/channelmonitor.rs 85.03% <66.66%> (ø) ⬆️
lightning/src/ln/functional_test_utils.rs 94.7% <96.77%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b76c77...cabb864. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant