Skip to content

Add a Config option to disable forwarding #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Jun 24, 2021 · 1 comment
Closed

Add a Config option to disable forwarding #969

TheBlueMatt opened this issue Jun 24, 2021 · 1 comment
Assignees
@TheBlueMatt
Milestone
0.0.100

Comments

@TheBlueMatt
Copy link
Collaborator

Private nodes should never accept a forwarded HTLC. Sure, there should be no reason anyone would ever want to forward through one either, but we currently don't have a config option to reject them which we should as they can have security implications.
@TheBlueMatt TheBlueMatt added this to the 0.0.99 milestone Jun 24, 2021
@TheBlueMatt TheBlueMatt self-assigned this Jun 25, 2021
@TheBlueMatt
Copy link
Collaborator Author

Assigning myself as I have some other config changes I wanna do as well.

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jun 26, 2021
@TheBlueMatt
(XXX TEST) Optionally reject HTLC forwards over priv chans with a new…
c41c287 
… config

Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jun 27, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
0e453be 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jun 28, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
a1a358a 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jun 29, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
6ffdd9a 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 1, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
25c9f5d 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 2, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
7ee87ab 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 3, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
e7aa1f8 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.99, 0.0.100 Jul 3, 2021
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
9660ca9 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
5b15ad4 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
38e7521 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
15450c4 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
valentinewallace pushed a commit to valentinewallace/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt @valentinewallace
Optionally reject HTLC forwards over priv chans with a new config
c58fc87 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969

f improve comment wording somewhat
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
d57f1d7 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 5, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
699e53f 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 6, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
783b151 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 6, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
aab0347 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 6, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
42cecaf 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
valentinewallace pushed a commit to valentinewallace/rust-lightning that referenced this issue Jul 6, 2021
@TheBlueMatt @valentinewallace
Optionally reject HTLC forwards over priv chans with a new config
6e8d873 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969

f improve comment wording somewhat

f more test comments
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 7, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
18d18f7 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 7, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
6df6c61 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 7, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
1eed3b8 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 8, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
56af54a 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 9, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
8856112 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 9, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
908c60f 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 9, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
ea8953b 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 9, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
1456e7a 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Jul 9, 2021
@TheBlueMatt
Optionally reject HTLC forwards over priv chans with a new config
1de7d8f 
Private nodes should never wish to forward HTLCs at all, which we
support here by disabling forwards out over private channels by
default. As private nodes should not have any public channels, this
suffices, without allowing users to disable forwarding over
channels announced in the routing graph already.

Closes lightningdevkit#969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
None yet
Projects
None yet
Milestone
0.0.100
Development

No branches or pull requests
1 participant
@TheBlueMatt