Skip to content

Clean up block connection logging in ChainMonitor/ChannelMonitor #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Jun 30, 2021 · 0 comments · Fixed by #1048
Closed

Clean up block connection logging in ChainMonitor/ChannelMonitor #980

TheBlueMatt opened this issue Jun 30, 2021 · 0 comments · Fixed by #1048
Milestone
0.0.101

Comments

@TheBlueMatt
Copy link
Collaborator

We should improve the logging to be less redundant and increase coverage of what's going on, especially at debug level. See #970 (comment)
@TheBlueMatt TheBlueMatt modified the milestones: 0.1, 0.0.100 Jun 30, 2021
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.100, 0.0.101 Aug 10, 2021
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Aug 17, 2021
@TheBlueMatt
Log chain calls in ChainMonitor, reducing logs in ChannelMonitor
cf84655 
For users with many ChannelMonitors, we log a large volume per
block simply because each ChannelMonitor lots several times per
block. Instead, we move to log only once at the TRACE level per
block call in ChannelMonitors, relying instead on a DEBUG level
log in ChainMonitor before we call any ChannelMonitor functions.

For most users, this will reduce redundant logging and also log at
the DEBUG level for block events, which is appropriate.

Fixes lightningdevkit#980.
@TheBlueMatt TheBlueMatt mentioned this issue Aug 17, 2021
Merged
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Aug 17, 2021
@TheBlueMatt
Log chain calls in ChainMonitor, reducing logs in ChannelMonitor
df18652 
For users with many ChannelMonitors, we log a large volume per
block simply because each ChannelMonitor lots several times per
block. Instead, we move to log only once at the TRACE level per
block call in ChannelMonitors, relying instead on a DEBUG level
log in ChainMonitor before we call any ChannelMonitor functions.

For most users, this will reduce redundant logging and also log at
the DEBUG level for block events, which is appropriate.

Fixes lightningdevkit#980.
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Aug 17, 2021
@TheBlueMatt
Log chain calls in ChainMonitor, reducing logs in ChannelMonitor
1e7d479 
For users with many ChannelMonitors, we log a large volume per
block simply because each ChannelMonitor lots several times per
block. Instead, we move to log only once at the TRACE level per
block call in ChannelMonitors, relying instead on a DEBUG level
log in ChainMonitor before we call any ChannelMonitor functions.

For most users, this will reduce redundant logging and also log at
the DEBUG level for block events, which is appropriate.

Fixes lightningdevkit#980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.101
1 participant
@TheBlueMatt