Update to rust-secp256k1 v0.11 and rust-bitcoin v0.14 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandudey
reviewed
Aug 20, 2018
src/ln/channel.rs
Outdated
| @@ -679,8 +680,10 @@ impl Channel { | |||
| let txins = { | |||
| let mut ins: Vec<TxIn> = Vec::new(); | |||
| ins.push(TxIn { | |||
| prev_hash: self.channel_monitor.get_funding_txo().unwrap().txid, | |||
| prev_index: self.channel_monitor.get_funding_txo().unwrap().index as u32, | |||
| previous_output: BitcoinOutPoint { | |||
There was a problem hiding this comment.
Implementing From<BitcoinOutPoint> for OutPoint can make this more cleaner, you just call self.channel_monitor.get_funding_txo().unwrap().into().
TheBlueMatt
force-pushed
the
2018-08-secp-0.10
branch
from
625b6d4 to
edc11be
Compare
TheBlueMatt
changed the title
TheBlueMatt
force-pushed
the
2018-08-secp-0.10
branch
2 times, most recently
from
6bfc606 to
9f260b3
Compare
TheBlueMatt
force-pushed
the
2018-08-secp-0.10
branch
from
9f260b3 to
11e5975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.