Skip to content

Bump MSRV to 1.41.1. #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Bump MSRV to 1.41.1. #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f96dec2
Bump MSRV to 1.41.1.
TheBlueMatt Feb 8, 2022
9f277dc
Use "Minimum", not "Minmal" for MSRV.
TheBlueMatt Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ jobs:
platform: [ ubuntu-latest ]
toolchain: [ stable,
beta,
# 1.36.0 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister
1.36.0,
# 1.41.0 is Debian stable
1.41.0,
# 1.41.1 is MSRV for Rust-Lightning, lightning-invoice, and lightning-persister
1.41.1,
# 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, and coverage generation
1.45.2,
# 1.47.0 will be the MSRV for no-std builds using hashbrown once core2 is updated
Expand Down Expand Up @@ -41,11 +39,9 @@ jobs:
- toolchain: beta
build-net-tokio: true
build-no-std: true
- toolchain: 1.36.0
- toolchain: 1.41.1
build-no-std: false
test-log-variants: true
- toolchain: 1.41.0
build-no-std: false
- toolchain: 1.45.2
build-net-old-tokio: true
build-net-tokio: true
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ be covered by functional tests.
When refactoring, structure your PR to make it easy to review and don't
hestitate to split it into multiple small, focused PRs.

The Minimal Supported Rust Version is 1.36.0 (enforced by our GitHub Actions).
The Minimum Supported Rust Version is 1.41.1 (enforced by our GitHub Actions).

Commits should cover both the issue fixed and the solution's rationale.
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.
Expand Down