Skip to content

Drop useless mut in KeysInterface::sign_holder_anchor_input #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

The Transaction is not modified so there's no reason to make the reference mut

The `Transaction` is not modified so there's no reason to make the
reference `mut`
@codecov-commenter
Copy link

Codecov Report

Base: 90.72% // Head: 90.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f63df16) compared to base (2e343e7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1805      +/-   ##
==========================================
- Coverage   90.72%   90.72%   -0.01%     
==========================================
  Files          87       87              
  Lines       47364    47364              
  Branches    47364    47364              
==========================================
- Hits        42970    42969       -1     
- Misses       4394     4395       +1     
Impacted Files Coverage Δ
lightning/src/chain/keysinterface.rs 89.40% <ø> (ø)
lightning/src/util/enforcing_trait_impls.rs 86.17% <ø> (ø)
lightning/src/chain/onchaintx.rs 95.06% <0.00%> (-0.23%) ⬇️
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (-0.03%) ⬇️
lightning/src/ln/channelmanager.rs 85.18% <0.00%> (+0.02%) ⬆️
lightning/src/ln/monitor_tests.rs 99.55% <0.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 4ec4e89 into lightningdevkit:main Oct 27, 2022
TheBlueMatt added a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants