Trivial #1910 Followups #1931
Merged
Trivial #1910 Followups #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
approved these changes
Dec 21, 2022
| /// By parameterizing by the raw invoice bytes instead of the hash, we allow implementors of | ||
| /// this trait to parse the invoice and make sure they're signing what they expect, rather than | ||
| /// blindly signing the hash. | ||
| /// The hrp is ascii bytes, while the invoice data is base32. |
There was a problem hiding this comment.
Really curious how the hell this happened, considering I copied and pasted. My guess is a commit after opening the PR that I intermittently hadn't rebased on.
There was a problem hiding this comment.
I think there were multiple places in the code that had the same comment, the diff showed it twice, but I couldn't really figure it out. Either way clearly the capitalized (and tick'd) version is better.
wpaulino
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups from the last round of review at #1910 (review)