Skip to content

169 Tweaked #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2018
Merged

169 Tweaked #234

merged 3 commits into from
Oct 31, 2018

Conversation

TheBlueMatt
Copy link
Collaborator

This is #169 with a number of changes:

  • numerous whitespace cleanups, missing spaces, spaces/tabs, extra spaces, etc.
  • apply limits to both inbound and outbound channels where appropriate
  • clarify docs significantly
  • fix one bug found by tests which was worked around in Add optional user specified channel limits of bolt 2  #169 instead of being fixed, and fix another bug which came up when reviewing

@TheBlueMatt TheBlueMatt mentioned this pull request Oct 31, 2018
Closed
TheBlueMatt and others added 3 commits October 31, 2018 15:45
@TheBlueMatt
Use non-funder's funding block wait instead of max with ours
55a74b5 
This is both required by the protocol and also makes sense - if
we're the funder we don't mind accepting payment on the channel
after one confirmation because we assume we won't double-spend
ourselves.
@TheBlueMatt
Require at least 1k sat for outbound channels and meet BTC's dust
9189d0e
@SWvheerden @TheBlueMatt
Added config interface to allow users to specify channel limits
a0be4d1
@TheBlueMatt TheBlueMatt merged commit 827a525 into lightningdevkit:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBlueMatt @SWvheerden