Avoid panic when 0conf channel's ann. sigs race on-chain confirmation #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A channel's `short_channel_id` is currently only set when the funding transaction is confirmed via `transactions_confirmed`, which might be well after the channel initally becomes usable, e.g., in the 0conf case. Previously we would panic due to a reachable `unwrap` when receiving a counterparty's `announcement_signatures` message for a 0conf channel pending confirmation on-chain. Here we fix this bug by avoiding unsafe `unwrap`s and just erroring out and ignoring the announcement_signatures message if the `short_channel_id` hasn't been set yet.
While this is currently not reachable, it's still cleaner to avoid the `unwrap` and return `None` if `short_channel_id` hasn't been set yet.
wpaulino
approved these changes
Jul 21, 2023
jkczyz
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A channel's
short_channel_idis currently only set when the funding transaction is confirmed viatransactions_confirmed, which might be well after the channel initially becomes usable, e.g., in the 0conf case.Previously we would panic due to a reachable
unwrapwhen receiving a counterparty'sannouncement_signaturesmessage for a 0conf channel pending confirmation on-chain.Here we fix this bug by avoiding unsafe
unwraps and just erroring out and ignoring theannouncement_signaturesmessage if theshort_channel_idhasn't been set yet.