Skip to content

Handle-initial_routing_sync-requests-from-peers-in-their-Init-messages #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Handle-initial_routing_sync-requests-from-peers-in-their-Init-messages #247

merged 1 commit into from
Nov 13, 2018

Conversation

TheBlueMatt
Copy link
Collaborator

#202 rebased and cleaned up a bunch.

  • Rejigger the Router API to where it was to avoid the return-value-by-mutable-reference pattern (this also avoids exposing peer_handler-specific internal APIs)
  • Clean up inconsistent spacing/indentation
  • Unify storing of relayable messages with our current should-we-relay checks (fixing DoS in node_announce storage)
  • Add TODO for race in backfilling updates mid-update-for-a-channel

@TheBlueMatt TheBlueMatt mentioned this pull request Nov 9, 2018
Closed
@TheBlueMatt TheBlueMatt force-pushed the 2018-11-202-redux branch 2 times, most recently from f834c04 to 4d936e7 Compare November 9, 2018 03:13
@TheBlueMatt
Copy link
Collaborator Author

There are enough changes here I'd love a once-over from @SWvheerden

SWvheerden
SWvheerden approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see any problems here

@TheBlueMatt TheBlueMatt merged commit 2be7c5d into lightningdevkit:master Nov 13, 2018
@TheBlueMatt TheBlueMatt mentioned this pull request Nov 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBlueMatt @SWvheerden