Misc Tweaks #253
Merged
Misc Tweaks #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought I found a bug in one-side-funded-first reconnect, but seems I can't reproduce it here. Either way worth improving the test coverage.
ariard
reviewed
Nov 15, 2018
| @@ -6636,20 +6636,28 @@ mod tests { | |||
| _ => panic!("Unexpected event"), | |||
| } | |||
|
|
|||
| reconnect_nodes(&nodes[0], &nodes[1], (false, true), (0, 0), (0, 0), (0, 0), (0, 0), (false, false)); | |||
There was a problem hiding this comment.
What was the kind of bug ? (for the record if one of us beach on it again)
There was a problem hiding this comment.
I saw some issue running rust-lightning-bitcoincorerpc opening an outbound channel then restarting when the remote side had sent its funding_locked but we had not yet sent ours.
|
ACK, good to protect user against its own mistakes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bit of test, clarify some internal interfaces somewhat and panic on misuse if the user creates funding transactions which aren't witness-inputs-only as requested by @ariard.