Skip to content

Don't FC when a channel_update has a bogus htlc_minimum_msat #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Don't FC when a channel_update has a bogus htlc_minimum_msat #2611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9123d6d
Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`
TheBlueMatt Sep 28, 2023
d66d38e
Log full channel_update messages received for our channels
TheBlueMatt Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lightning/src/ln/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5538,9 +5538,6 @@ impl<SP: Deref> Channel<SP> where
}

pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
if msg.contents.htlc_minimum_msat >= self.context.channel_value_satoshis * 1000 {
return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should log it still?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, I'll just log the full message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We log the update, but don't log that it was bogus htlc_minimum_msat?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but we also don't do anything with it so its not really an error that's interesting. We should maybe consider not ignoring it, but the spec isn't super clear on if we have to honor it anyway. In any case, the full message with all its fields is probably more interesting than something specific to one field.

}
self.context.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
fee_base_msat: msg.contents.fee_base_msat,
fee_proportional_millionths: msg.contents.fee_proportional_millionths,
Expand Down