Harden test for logging of inbound htlc being resolved #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this guaranteed? Can we just debug_assert!() it? |
ariard
force-pushed
the
harden-inbound-htlc-resolved
branch
from
adec08a to
cb53ae7
Compare
|
Oh in fact no, we forgot to log apart offered HTLC being resolved by HTLC-timeout, have a look on test_justice_tx (HTLC-timeout on revoked remote commitment tx) or test_htlc_ignore_latest_remote_commitment_tx (HTLC-timeout on remote commitment tx) |
|
Oops, right, confused myself between has-source and outbound-on-transaction when we are running this on both remote and local commitment transactions. I guess for local commitment transactions this is guaranteed for remote commitment transactions it's guaranteed not to be.
I'll go ahead and take this but I'm in the middle of refactoring HTLC storage to make local and remote look similar to fix the TODOs in would_broadcast.
… On Jan 2, 2019, at 21:10, ariard ***@***.***> wrote:
Oh in fact no, we forgot to log apart offered HTLC being resolved by HTLC-timeout, have a look on test_justice_tx (HTLC-timeout on revoked remote commitment tx) or test_htlc_ignore_latest_remote_commitment_tx (HTLC-timeout on remote commitment tx)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nit, but occured to me while reviewing 278 than we could harden test there (timeout tx resolving inbound htlc output nothing to broadcast/pass upstream, just logging)