Async Send Simple Hold #3957
Draft
Async Send Simple Hold #3957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! I see this is a draft PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3957 +/- ##
==========================================
- Coverage 88.93% 88.93% -0.01%
==========================================
Files 174 174
Lines 123876 123905 +29
Branches 123876 123905 +29
==========================================
+ Hits 110173 110198 +25
- Misses 11250 11253 +3
- Partials 2453 2454 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified variant for sending of async payments that doesn't use trampoline. The sender LSP receives an HTLC from the sender indicating that the HTLC should be held. Sender LSP then sends out
HeldHtlcAvailableto the receiver LSP. Receiver LSP replies withReleaseHeldHtlc. Upon receiving this onion message, sender LSP release the held htlc and lets it continue along the sender-determined path.